[PATCH] D108760: [M68k] Add parsing support for more operand types

[Min-Yih Hsu via Phabricator via llvm-commits]

myhsu added a comment.

Thank you for taking a look into this :-)
If we use the addressing mode designators listed here <https://github.com/llvm/llvm-project/blob/84cbd71c95923f9912512f3051c6ab548a99e016/llvm/lib/Target/M68k/M68kInstrFormats.td#L13>, I think the problem here is that you want to implement asm parsing logic for 'v', 'u', and 'g'. But we don't even have those addressing modes in the instruction definitions yet (almost all supported addressing modes are listed here <https://github.com/llvm/llvm-project/blob/2e83a0efb9065fdc526b92cfe0f89ca53ca547d7/llvm/lib/Target/M68k/M68kInstrInfo.td#L565>).
I prefer to have complete codegen + asm parsing support for these three addressing modes instead of only the asm parsing part as presented here. You can, for example, have three separate patches in which each of them contains full support for one of the said addressing modes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108760/new/

https://reviews.llvm.org/D108760