[PATCH] D108760: [M68k] Add parsing support for more operand types

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 26 06:04:04 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/M68k/AsmParser/M68kAsmParser.cpp:86
 struct M68kMemOp {
   enum class Kind {
     Addr,
----------------
ricky26 wrote:
> jrtc27 wrote:
> > Needs rebasing to use KindTy
> Actually, that's a different enum. `KindTy` is in M68kOperand. Perhaps I should rename this one too?
Oh right. This one's fine, the variable's called Op so no conflicts.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108760/new/

https://reviews.llvm.org/D108760



More information about the llvm-commits mailing list