[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0-rc1 spec

[Kito Cheng via Phabricator via llvm-commits]

kito-cheng added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:72
+    {"zvl512b", RISCVExtensionVersion{0, 10}},
+    {"zvl1024b", RISCVExtensionVersion{0, 10}},
 
----------------
kito-cheng wrote:
> Although the table in vector spec only list `zvl32b`~`zvl1024b`, but there is note say `Longer vector length extensions should follow the same pattern.`[1], so I would suggest let enumerate to 65536, the unbound of VLEN[2],  
> 
> 
> [1] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#181-zvl-minimum-vector-length-standard-extensions
> [2] https://github.com/riscv/riscv-v-spec/blob/master/v-spec.adoc#2-implementation-defined-constant-parameters
Oh, typo, unbound should be upper bound :p


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108694/new/

https://reviews.llvm.org/D108694