[PATCH] D108724: [LoopPredication] Preserve MemorySSA

[Anna Thomas via Phabricator via llvm-commits]

anna marked 4 inline comments as done.
anna added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:382
+  auto PA = getLoopPassPreservedAnalyses();
+  PA.preserve<MemorySSAAnalysis>();
+  return PA;
----------------
asbirlea wrote:
> This needs to be under the conditional too:
> ```
> if (AR.MSSA)
>   PA.preserve<MemorySSAAnalysis>();
> ```
> 
missed it, thanks.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:825
   Guard->setOperand(0, AllChecks);
-  RecursivelyDeleteTriviallyDeadInstructions(OldCond);
+  RecursivelyDeleteTriviallyDeadInstructions(OldCond, nullptr /* TLI */, MSSAU);
 
----------------
nikic wrote:
> There's another RecursivelyDeleteTriviallyDeadInstructions() use in the function below, needs to be adjusted as well?
Thank you! good catch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108724/new/

https://reviews.llvm.org/D108724