[PATCH] D108724: [LoopPredication] Preserve MemorySSA

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LoopPredication.cpp:382
+  auto PA = getLoopPassPreservedAnalyses();
+  PA.preserve<MemorySSAAnalysis>();
+  return PA;
----------------
This needs to be under the conditional too:
```
if (AR.MSSA)
  PA.preserve<MemorySSAAnalysis>();
```



================
Comment at: llvm/test/Transforms/LoopPredication/widened.ll:3
 ; RUN: opt -S -loop-predication -loop-predication-enable-iv-truncation=true < %s 2>&1 | FileCheck %s
+; RUN: opt -S -passes='require<scalar-evolution>,loop-mssa(loop-predication)' < %s 2>&1 | FileCheck %s
 declare void @llvm.experimental.guard(i1, ...)
----------------
Add `-verify-memoryssa `.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108724/new/

https://reviews.llvm.org/D108724