[PATCH] D108614: [NFC] Rename attribute methods that work with indexes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

In D108614#2962854 <https://reviews.llvm.org/D108614#2962854>, @dexonsmith wrote:

> Change SGTM. New names seem more clear / less dangerous. @bogner, @fhahn, or @t.p.northover, any thoughts?
>
> BTW, staging this as (at least) two commits will make this easier for downstreams:
>
> 1. Add new APIs and update callers, leaving behind the old names forwarding to the new ones (for a bigger commit you might want to split this step up further)
> 2. Remove old APIs
>
> That way a downstream can temporarily revert the "Remove old APIs" commit and continuing merging from main, while updating their own code as a background task. (No need to wait really for "Remove old APIs"; as long as it's an easy-to-revert standalone commit then there are good workflows for downstreams.)

Renaming these methods downstream should be fairly straightforward and quick, I don't think we need to make it easier for downstream users to adapt to this change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108614/new/

https://reviews.llvm.org/D108614