[PATCH] D108614: [NFC] Rename attribute methods that work with indexes

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 10:35:30 PDT 2021


dexonsmith added reviewers: bogner, t.p.northover, fhahn.
dexonsmith added subscribers: fhahn, bogner, t.p.northover.
dexonsmith added a comment.

Change SGTM. New names seem more clear / less dangerous. @bogner, @fhahn, or @t.p.northover, any thoughts?

BTW, staging this as (at least) two commits will make this easier for downstreams:

1. Add new APIs and update callers, leaving behind the old names forwarding to the new ones (for a bigger commit you might want to split this step up further)
2. Remove old APIs

That way a downstream can temporarily revert the "Remove old APIs" commit and continuing merging from main, while updating their own code as a background task. (No need to wait really for "Remove old APIs"; as long as it's an easy-to-revert standalone commit then there are good workflows for downstreams.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108614/new/

https://reviews.llvm.org/D108614



More information about the llvm-commits mailing list