[PATCH] D108628: [lld/COFF] Improve handling of the /manifestdependency: flag

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

Thanks!



================
Comment at: lld/COFF/Config.h:184
   int manifestID = 1;
-  StringRef manifestDependency;
+  llvm::SetVector<StringRef> manifestDependencies;
   bool manifestUAC = true;
----------------
rnk wrote:
> I worry that MSVC may do more things to deduplicate manifest files. They could canonicalize the path first and ignore case, for example. However, I really don't think it matters. The main thing is that repeated, identical directives should not add the same file twice, and this handles that well enough.
This flag doesn't contain a path, but raw text that's copied into the manifest xml. As far as I can tell (`link main.obj /manifestdependency:foo=bar /manifestdependency:Foo=bar ; type foo.exe.manifest`) both an additional space or a difference just in upper/lowercase makes link.exe emit ore than one dependentAssembly element.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108628/new/

https://reviews.llvm.org/D108628