[PATCH] D108628: [lld/COFF] Improve handling of the /manifestdependency: flag

[Reid Kleckner via Phabricator via llvm-commits]

rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: lld/COFF/Config.h:184
   int manifestID = 1;
-  StringRef manifestDependency;
+  llvm::SetVector<StringRef> manifestDependencies;
   bool manifestUAC = true;
----------------
I worry that MSVC may do more things to deduplicate manifest files. They could canonicalize the path first and ignore case, for example. However, I really don't think it matters. The main thing is that repeated, identical directives should not add the same file twice, and this handles that well enough.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108628/new/

https://reviews.llvm.org/D108628