[PATCH] D108585: [DebugInfo][InstrRef] Don't use instruction referencing for unoptimised functions

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 25 04:02:44 PDT 2021


jmorse updated this revision to Diff 368601.
jmorse added a comment.

Ouch, looks like I missed several things: I was intending that functions marked optnone would have instr-ref disabled too, I've added that filter into this patch, and expanded the test case to have an optnone function that always gets a DBG_VALUE.

Additionally there were a bunch of sites where the command-line-option was being tested rather than using this utility method, I'd failed to grep properly for it, oooff. Revised patch modifies all uses of the command line option flag to use the utility method instead. I've also added a RUN line in the test for fast-isel, to check that it behaves the same way as normal isel.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108585/new/

https://reviews.llvm.org/D108585

Files:
  llvm/include/llvm/CodeGen/MachineFunction.h
  llvm/lib/CodeGen/LiveDebugValues/LiveDebugValues.cpp
  llvm/lib/CodeGen/LiveDebugVariables.cpp
  llvm/lib/CodeGen/MachineFunction.cpp
  llvm/lib/CodeGen/SelectionDAG/FastISel.cpp
  llvm/lib/CodeGen/SelectionDAG/InstrEmitter.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  llvm/test/DebugInfo/X86/instr-ref-opt-levels.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108585.368601.patch
Type: text/x-patch
Size: 9622 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210825/5e0e9e39/attachment.bin>


More information about the llvm-commits mailing list