[PATCH] D108585: [DebugInfo][InstrRef] Don't use instruction referencing for unoptimised functions

[Orlando Cazalet-Hyams via Phabricator via llvm-commits]

Orlando accepted this revision.
Orlando added a comment.
This revision is now accepted and ready to land.

LGTM with 2 small inline questions.



================
Comment at: llvm/include/llvm/CodeGen/MachineFunction.h:539-540
 
+  /// Returns true if functions variable locations should be tracked with
+  /// instruction referencing.
+  bool useDebugInstrRef() const;
----------------
Nit/question. Am I right in thinking this returns the same value for all MachineFunctions?
If so, then maybe this method should be static? And in the comment I think `functions` should just become `function` or be removed. Alternatively, if I'm wrong and this can return a different value for different MachineFunctions (or may do so in the future), then I think the comment should start `Returns true if the function's variable...`.


================
Comment at: llvm/test/DebugInfo/X86/instr-ref-opt-levels.ll:11
+; O0: DBG_VALUE
+; O2: DBG_VALUE
+
----------------
Should this be `O2: DBG_INSTR_REF` rather than `O2: DBG_VALUE`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108585/new/

https://reviews.llvm.org/D108585