[PATCH] D108628: [lld/COFF] Improve handling of the /manifestdependency: flag

Tue Aug 24 12:03:30 PDT 2021

thakis added a comment.

In D108628#2963094 <https://reviews.llvm.org/D108628#2963094>, @thakis wrote:

> Yet another option is to call `createResponseFile()` from the destructor of some RAII class so that it's always created as late as possible. That sounds like an ok option too.

One drawback of that is that that'd also add lib files referenced by e.g. `/defaultlib:` flags in `.drectve` entries from obj files to the response file, so that when replaying the link from the response file, we'd now see those libs twice (once from the response file, and another time from the `.drectve`).

It's probably best if the repro is as close as possible to the input, which suggests undoing D38975 <https://reviews.llvm.org/D38975>.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108628/new/

https://reviews.llvm.org/D108628