[PATCH] D108628: [lld/COFF] Improve handling of the /manifestdependency: flag

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 11:42:32 PDT 2021


thakis added a comment.

Another option is to extract a method that computes the name of the generated .res file and adds it to the response file eagerly, and only do so if we don't create an import lib or thin lto indices only. That'd work too, but it's also a bit brittle since it needs to match early exit patterns.

Yet another option is to call `createResponseFile()` from the destructor of some RAII class so that it's always created as late as possible. That sounds like an ok option too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108628/new/

https://reviews.llvm.org/D108628



More information about the llvm-commits mailing list