[PATCH] D108623: [flang] Fix non-deterministic line output function

Peter Klausler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 09:11:33 PDT 2021


klausler added inline comments.


================
Comment at: flang/lib/Semantics/check-declarations.cpp:1156
+  auto checkDefinedOperatorArgs = [&, opName, specific, proc]() {
+    bool arg0Defined = CheckDefinedOperatorArg(opName, specific, proc, 0);
+    bool arg1Defined = CheckDefinedOperatorArg(opName, specific, proc, 1);
----------------
We use modern C++ braced initialization in the front-end, as a rule, for better error detection.

You don't need parentheses on a `return` statement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108623/new/

https://reviews.llvm.org/D108623



More information about the llvm-commits mailing list