[PATCH] D108623: [flang] Fix non-deterministic line output function

Kiran Chandramohan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 24 05:46:14 PDT 2021


kiranchandramohan accepted this revision.
kiranchandramohan added a subscriber: klausler.
kiranchandramohan added a comment.
This revision is now accepted and ready to land.

LGTM. Please wait for approval from @klausler or @Meinersbur.



================
Comment at: flang/lib/Semantics/check-declarations.cpp:1155
   std::optional<parser::MessageFixedText> msg;
+  auto checkDefinedOperatorArgs = [&, opName, specific, proc]() {
+    bool arg0Defined = CheckDefinedOperatorArg(opName, specific, proc, 0);
----------------
Nit: You probably do not need "&"  in the capture list since you have explicitly captured the variables (opName, specific, proc) required.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108623/new/

https://reviews.llvm.org/D108623



More information about the llvm-commits mailing list