[PATCH] D108514: [TargetMachine] Move COFF special case for ExternalSymbolSDNode from shouldAssumeDSOLocal to X86Subtarget

Mon Aug 23 12:14:08 PDT 2021

mstorsjo accepted this revision.
mstorsjo added a comment.
This revision is now accepted and ready to land.

In D108514#2960293 <https://reviews.llvm.org/D108514#2960293>, @MaskRay wrote:

> FYI I use this script to test end-to-end behavior of .c => .s: https://gist.github.com/MaskRay/c03a90922003df666551589f1629df22

Awesome, thanks for being thorough in checking it!

I can't come up with anything else right now to check, so I guess there's no reason to hold this back then.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108514/new/

https://reviews.llvm.org/D108514