[PATCH] D108514: [TargetMachine] Move COFF special case for ExternalSymbolSDNode from shouldAssumeDSOLocal to X86Subtarget

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

FYI I use to test end-to-end behavior of .c => .s: https://gist.github.com/MaskRay/c03a90922003df666551589f1629df22

The following configurations's codegen stay unchanged. So this should be safe.

  run win.x86 -target x86_64-windows
  run win.x86.asan -target x86_64-windows -fsanitize=address
  run win.x86.coverage -target x86_64-windows -fprofile-instr-generate
  run win.x86.pgo -target x86_64-windows -fprofile-generate
  
  run mingw.x86 -target x86_64-windows-gnu
  run mingw.x86.nopic -target x86_64-windows-gnu -fno-pic
  run mingw.x86.asan -target x86_64-windows-gnu -fsanitize=address
  run mingw.x86.coverage -target x86_64-windows-gnu -fprofile-instr-generate
  run mingw.x86.pgo -target x86_64-windows-gnu -fprofile-generate
  
  run win.arm -target arm-windows
  run win.arm.asan -target arm-windows -fsanitize=address
  
  run win.a64 -target aarch64-windows
  run win.a64.asan -target aarch64-windows -fsanitize=address

If there is arm/aarch64 coverage issue, it can't be this patch's fault:)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108514/new/

https://reviews.llvm.org/D108514