[PATCH] D108432: [InstrProfiling] Keep profd non-private for non-renamable comdat functions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D108432#2956919 <https://reviews.llvm.org/D108432#2956919>, @YolandaCY wrote:

> "This is super rare, but is possible with CSPGO (which can make a weak_odr function inlines its callees differently, sometimes with value profiling while sometimes without)."
>
> This may not be an issue to CSPGO, if the IRPGOFlag can be correctly handled as addressed at https://reviews.llvm.org/D107034.
> So this may only happen with -fprofile-instr-generate, which should be in a rare case (not sure if it's possible), but not specific to CSPGO.

Replied there. I think `isIRPGOFlagSet(M)` => `enablesValueProfiling(*M)` is not correct.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108432/new/

https://reviews.llvm.org/D108432