[PATCH] D108432: [InstrProfiling] Keep profd non-private for non-renamable comdat functions

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 20 15:28:10 PDT 2021


MaskRay added a comment.

In D108432#2958278 <https://reviews.llvm.org/D108432#2958278>, @davidxl wrote:

> This looks reasonable. How much size impact does this patch have?

With this change, a stage 2 (`-DLLVM_TARGETS_TO_BUILD=X86 -DLLVM_BUILD_INSTRUMENTED=IR`)
clang is 0.08% larger (172431496/172286720-1).
`stat -c %s **/*.o | awk '{s+=$1}END{print s}' is 0.026% larger.
The majority of D103717 <https://reviews.llvm.org/D103717>'s benefits remains.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108432/new/

https://reviews.llvm.org/D108432



More information about the llvm-commits mailing list