[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

[John McCall via Phabricator via llvm-commits]

rjmccall added a comment.

I have no problem with breaking LLVM analyses that rely on record types being filled in when they don't need to be.  I've been consistently telling people for years that they shouldn't be relying on IR types for things like that.

I would stick with the frontend terminology of a "complete" type, though.  And you might consider adding a function to CGT which completes a type, both for clarity and so that you can fast-path the common case where you've already got a sized type.

You can probably rip out the UpdateCompletedType logic when you're done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108407/new/

https://reviews.llvm.org/D108407