[PATCH] D108407: [CodeGen][WIP] Avoid generating Record layouts for pointee types

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 19 15:18:51 PDT 2021


dblaikie added a comment.

Notion seems plausible - though if there's some way to refactor so there's less need for manual insertion/maintenance of calls to `ConvertTypeForMem` that'd be good/important. I don't think there'd be anything fundamentally wrong with this approach - though checking some workloads to see if you can get bit identical results (eg: does some interesting binaries (including a clang selfhost) built with/without this patch compile to exactly the same file?) would probably be a good place to start to check the soundness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108407/new/

https://reviews.llvm.org/D108407



More information about the llvm-commits mailing list