[PATCH] D107016: [DebugInfo][LoopStrengthReduction] Ensure restoration of cached DIExpression when using SCEV-based salvaging

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added a comment.

Hmm, actually I hate to suddenly jump in with a broader objection (especially after I already reviewed this earlier), but is this change needed? I think the reason that the cached DIExpression restoration is only needed for arglists is because it will cause an error if we have a mismatch between the number of ArgList elements and the number of elements referenced in the DIExpression; we don't (I think) otherwise care about whether the expression is restored or not, because it should be undef regardless (otherwise it wouldn't have been salvaged).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107016/new/

https://reviews.llvm.org/D107016