[PATCH] D107016: [DebugInfo][LoopStrengthReduction] Ensure restoration of cached DIExpression when using SCEV-based salvaging

Chris Jackson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 00:42:04 PDT 2021


chrisjackson added a comment.

To be clear why I don't currently have a test, this change resulted from inspection of the source and I'm confident the scenario (LSR modifying the DIExpression alone and not the number of location operands) can occur and the patched behaviour is correct. So, currently I have no reproducer. However, I'm prepared to try and generate one. But, as there are no restrictions on the salvaging behvaiour of LSR, even if the scenario does not occur now, it may in future.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107016/new/

https://reviews.llvm.org/D107016



More information about the llvm-commits mailing list