[PATCH] D104639: [AIX][XCOFF] Add support for 64-bit file header and section header writing

[Maryam via Phabricator via llvm-commits]

MaryamBen added a comment.

When I did this work, I had no idea that I could remove "64-bit XCOFF object files are not supported yet." in order to create tests.
Unfortunately, I learned this late, 
Thank you so much for your clarifications.



================
Comment at: llvm/include/llvm/BinaryFormat/XCOFF.h:30
 constexpr size_t FileHeaderSize32 = 20;
+constexpr size_t FileHeaderSize64 = 24;
 constexpr size_t SectionHeaderSize32 = 40;
----------------
sfertile wrote:
> I'm not sure why these changes are showing up in this patch as they are all landed upstream already (they landed in the patch adding support for yaml2obj support for xcoff)
I think the patch you are talking about was recently merged. 
When I created the pacth (2 months ago) , these changes weren't applied.



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:78
   const MCSectionXCOFF *const MCCsect;
-  uint32_t SymbolTableIndex;
-  uint32_t Address;
-  uint32_t Size;
+  uint64_t SymbolTableIndex;
+  uint64_t Address;
----------------
sfertile wrote:
> Isn't the 64-bit object format also limited to a 4 byte symbol table index?
Yes I made a mistake, I will change it right now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104639/new/

https://reviews.llvm.org/D104639