[PATCH] D108362: [NewPM] Use parameterized syntax for a couple of more passes

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 19 11:54:40 PDT 2021


asbirlea accepted this revision.
asbirlea added a comment.

Thank you for this cleanup.



================
Comment at: llvm/lib/Passes/PassRegistry.def:350
+                          parseEarlyCSEPassOptions,
+                          "memssa")
+FUNCTION_PASS_WITH_PARAMS("ee-instrument",
----------------
A cleanup follow up: for naming consistency, this can be updated to "memoryssa"?
The tests below will become `-passes='require<memoryssa>,invalidate<aa>,early-cse<memoryssa>'`
This will need updating the legacy PM naming and all tests, so I don't expect it to be included in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108362/new/

https://reviews.llvm.org/D108362



More information about the llvm-commits mailing list