[PATCH] D108362: [NewPM] Use parameterized syntax for a couple of more passes

Thu Aug 19 11:11:46 PDT 2021

aeubanks accepted this revision.
aeubanks added inline comments.
This revision is now accepted and ready to land.

================
Comment at: llvm/tools/opt/NewPMDriver.cpp:427
       ModifiedPassName = "require<" + ModifiedPassName + ">";
+    else if (ModifiedPassName == "early-cse-memssa")
+      ModifiedPassName = "early-cse<memssa>";
----------------
bjope wrote:
> aeubanks wrote:
> > we can probably delete RUN lines from tests that the legacy PM with these passes
> I also think that this is kind of an ugly workaround (at least unless we can phase out the `-enable-new-pm` hack quite soon). But as long as we support `-enable-new-pm=1` together with the legacy syntax for specifying passes to run I believe that the alternative would be to add these passes to the list of passes that force legacy PM. Because it is impossible to use the new names including '<>' without also using `-passes='...'`.
> 
> A bit sad that your RFC to start clean up lit tests from using `-enable-new-pm` didn't get more attention. But maybe that at least was a sign that there isn't that many objections to move forward with cleaning up uses of `-enable-new-pm`.
that's fair. can you add a TODO to delete once we've cleaned up tests?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108362/new/

https://reviews.llvm.org/D108362