[PATCH] D104646: [AIX][XCOFF] 64-bit relocation reading support

[Sean Fertile via Phabricator via llvm-commits]

sfertile added inline comments.


================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:727
+  const T &Section = static_cast<const T &>(Sec);
+  if (is64Bit())
+    return Section.NumberOfRelocations;
----------------
daltenty wrote:
> nit: maybe we'd benefit from an assert or some other way to make sure the type T and the bitmode agree?
This is a good suggestion. As an alternative (and it can come as a post commit NFC patch if need be) would it make sense to specialize this for both valid section header types since the implementation is not the same for 32-bit vs 64-bit?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104646/new/

https://reviews.llvm.org/D104646