[PATCH] D104646: [AIX][XCOFF] 64-bit relocation reading support

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 09:02:42 PDT 2021


daltenty accepted this revision as: daltenty.
daltenty added a comment.

LGTM, apart from minor nits (and possibly follow on  tests). I can assist with committing this once you're ready.



================
Comment at: llvm/lib/Object/XCOFFObjectFile.cpp:727
+  const T &Section = static_cast<const T &>(Sec);
+  if (is64Bit())
+    return Section.NumberOfRelocations;
----------------
nit: maybe we'd benefit from an assert or some other way to make sure the type T and the bitmode agree?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104646/new/

https://reviews.llvm.org/D104646



More information about the llvm-commits mailing list