[PATCH] D105853: [ISel] Expand saddsat and ssubsat via asr and xor

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 02:52:28 PDT 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:1036
 
+    bool preferExpandSAddSubSatViaAsrXor(unsigned Opcode, EVT VT) const override;
+
----------------
RKSimon wrote:
> I think we're better off avoiding this if we can - if you revert this change I'll add a X86 custom lowering and email it to you.
It is quite ugly. I can take another looks at trying to custom lower it - there are just quite a few combinations.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105853/new/

https://reviews.llvm.org/D105853



More information about the llvm-commits mailing list