[PATCH] D108147: [SamplePGO][NFC] Dump function profiles in order

Tue Aug 17 18:08:18 PDT 2021

rupprecht added a comment.

FYI, I ran into this commit when pulling into our downstream fork because we had some tests comparing expected profile dump output. Usually labeling a commit as "NFC" is reserved for patches that have no externally visible effect, but this changes the output of `llvm-profdata show`. See https://lists.llvm.org/pipermail/llvm-dev/2021-June/151234.html for recent discussion. I can certainly see this being a bit of an edge case.

(No objection to the patch itself, and we didn't see any ill effect so far, just wanted to mention this in case it was unexpectedly not-NFC, or in case anyone else runs across this commit.)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108147/new/

https://reviews.llvm.org/D108147