[PATCH] D107041: [Flang] Ported test_symbols to Python

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 03:52:45 PDT 2021


awarzynski added a comment.

In D107041#2947172 <https://reviews.llvm.org/D107041#2947172>, @Meinersbur wrote:

> Your linked readme suggests that the source is checked out in `~/flang/src`.

That's a typo and probably a leftover from when F18 <https://reviews.llvm.org/F18> was a separate project (i.e. before merging into llvm-project). Updated in https://reviews.llvm.org/D108198.

> This does not correspond to structure from a git clone of the llvm-project repository.

When I test "standalone" builds, I clone llvm-project once, but then build twice (i.e. in two stages). I'm not sure whether that's the intended workflow - I only use it when testing changes that can potentially break it.

> Why not just ask cmake to use that directory for the source directory?

But with LLVM's CMake. you can't really build just one sub-project, can you?

We don't really use this workflow, so we just focus on making sure that our changes don't break it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107041/new/

https://reviews.llvm.org/D107041



More information about the llvm-commits mailing list