[PATCH] D107041: [Flang] Ported test_symbols to Python

[Michael Kruse via Phabricator via llvm-commits]

Meinersbur added a comment.

In D107041#2946300 <https://reviews.llvm.org/D107041#2946300>, @awarzynski wrote:

> In the context of LLVM Flang, "out-of-tree" usually means that Flang itself is out-of-tree: https://github.com/llvm/llvm-project/tree/main/flang#building-flang-out-of-tree. This means building in two stages:
>
> - stage 1 - build LLVM, MLIR, Clang
> - stage 2 - build Flang against the binaries generated in stage 1 (i.e. as if Flang was an out-of-tree project)

This would usually be referred to as a standalone build: https://github.com/llvm/llvm-project/blob/94b4598d77fe0585a8a3bd2a798fc7ce15a6aa56/flang/CMakeLists.txt#L25

> In this workflow, LLVM Flang is like an independent project. It's more like "out-of-tree development" than "out-of-tree build" and `.gitignore` from LLVM doesn't really exist in this set-up.

Your linked readme suggests that the source is checked out in `~/flang/src`. This does not correspond to structure from a git clone of the llvm-project repository. Maybe it's a symlink to the flang directory of the llvm-project repository? Why not just ask cmake to use that directory for the source directory? However, I also don't have any problem with adding additional files to flang's `.gitignore` (D108057 <https://reviews.llvm.org/D108057>) but would ask someone who thinks it is useful to approve that patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107041/new/

https://reviews.llvm.org/D107041