[PATCH] D107954: Make test_symbols.py compare files line-by-line

Ivan Zhechev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 02:40:53 PDT 2021


ijan1 marked an inline comment as done.
ijan1 added a comment.

In D107954#2941348 <https://reviews.llvm.org/D107954#2941348>, @awarzynski wrote:

> Makes a lot of sense, but I would rephrase the summary a bit. Basically, you are making sure here that you are comparing the files line by line rather than the whole thing at a time. By making sure that the comparison is done line-by-line, you also make the output much nicer. Perhaps:

Thanks for the suggested summary! I've updated accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107954/new/

https://reviews.llvm.org/D107954



More information about the llvm-commits mailing list