[PATCH] D106940: Fix test for debug dir presence

[Alfonso Sanchez-Beato via Phabricator via llvm-commits]

alfonsosanchezbeato added a comment.

In D106940#2946447 <https://reviews.llvm.org/D106940#2946447>, @jhenderson wrote:

> The pre-merge checks are saying that this new test fails...

I think that the problem is that the binary has not been properly imported, as the error is "The file was not recognized as a valid object file". I generated the diff with `git show HEAD --binary -U999999`, maybe the diff needs to be generated in a different way so phabricator generates a good binary?

> I'm not too familiar with yaml2obj's COFF version, but it might be good for you to take a quick look at what would be involved to add support for the new field you're proposing, rather than checking in a pre-canned binary. If it's not too complex, that would be the preferred approach.

I am not familiar with yaml2obj either, I've taken a look and I'm not sure how easy would it be to add something like that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106940/new/

https://reviews.llvm.org/D106940