[PATCH] D106940: Fix test for debug dir presence

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

The pre-merge checks are saying that this new test fails...

I'm not too familiar with yaml2obj's COFF version, but it might be good for you to take a quick look at what would be involved to add support for the new field you're proposing, rather than checking in a pre-canned binary. If it's not too complex, that would be the preferred approach.



================
Comment at: llvm/test/tools/llvm-objcopy/COFF/check-debug-dir-present.test:4-6
+# RUN: obj2yaml %t | FileCheck %s --check-prefixes=CHECK-ADD
+
+# CHECK-ADD:    NumberOfRvaAndSize: 6
----------------
CHECK is the default.


================
Comment at: llvm/test/tools/llvm-objcopy/COFF/check-debug-dir-present.test:8
+
+## We can use this yaml to generate the binary when we have support for a
+## variable NumberOfRvaAndSize in yaml2obj.
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106940/new/

https://reviews.llvm.org/D106940