[PATCH] D108137: [AArch64][Global ISel] Add sext/zext improvements

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 00:54:27 PDT 2021


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp:2148
   }
+
+  case TargetOpcode::G_ZEXT:
----------------
Rin wrote:
> paquette wrote:
> > Why did this code move?
> For the i64 case for G_SEXT we saw that it was choosing the tablegen patterns instead of the switch(Opcode). To avoid that, this code was moved to earlySelect.
Do we need to move all of this, or can we get away with just doing the i64 in earlySelect?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108137/new/

https://reviews.llvm.org/D108137



More information about the llvm-commits mailing list