[PATCH] D108016: [lld-macho] Ignore LLVM segments to prevent duplicate syms

Mon Aug 16 15:24:22 PDT 2021

thevinster marked an inline comment as done.
thevinster added inline comments.

================
Comment at: lld/MachO/InputFiles.cpp:283-284
     } else {
       auto *isec =
           make<ConcatInputSection>(segname, name, this, data, align, flags);
+      if (isDebugSection(isec->getFlags()) &&
----------------
int3 wrote:
> I realized that we are now constructing `isec` here redundantly whenever we have an `__LLVM` section. Can you fix things so that we only construct the isec when it actually gets used?
Created follow up - D108167

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108016/new/

https://reviews.llvm.org/D108016