[PATCH] D108016: [lld-macho] Ignore LLVM segments to prevent duplicate syms

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 16 14:49:32 PDT 2021


int3 added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:283-284
     } else {
       auto *isec =
           make<ConcatInputSection>(segname, name, this, data, align, flags);
+      if (isDebugSection(isec->getFlags()) &&
----------------
I realized that we are now constructing `isec` here redundantly whenever we have an `__LLVM` section. Can you fix things so that we only construct the isec when it actually gets used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108016/new/

https://reviews.llvm.org/D108016



More information about the llvm-commits mailing list