[PATCH] D108019: [NFC][llvm-xray] add a llvm-xray convert option `symbolize-no-demangle`

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-xray/X86/convert-with-debug-syms-no-demangle.txt:1
+; RUN: llvm-xray convert -m %S/Inputs/elf64-sample-o2.bin --symbolize --symbolize-no-demangle=true %S/Inputs/naive-log-simple.xray -f=yaml -o - 2>&1 | FileCheck %s
+
----------------
Enna1 wrote:
> MaskRay wrote:
> > This can be added to `X86/extract-instrmap-symbolize.ll` rather than add a new file.
> > This can be added to `X86/extract-instrmap-symbolize.ll` rather than add a new file.
> 
> `llvm xray convert` and `llvm xray extract` are different subcommand, to avoid adding a new file, perhaps add this to `X86/convert-with-debug-syms.txt` ?
SG.

Please also avoid options like `--foo=true`.
It works just because llvm CommandLine.cpp has such behaviors. Such options are not guaranteed to work in the future for user-facing utilities.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108019/new/

https://reviews.llvm.org/D108019