[PATCH] D108019: [NFC][llvm-xray] add a llvm-xray convert option `symbolize-no-demangle`

[Xu Mingjie via Phabricator via llvm-commits]

Enna1 added a comment.

In D108019#2945953 <https://reviews.llvm.org/D108019#2945953>, @MaskRay wrote:

> Perhaps switch to no-demangle by default and add `--symbolize-demangle`?

We should provide a consistent naming with `llvm-xray extract` ? `llvm-xray extract` use an option `no-demangle` and set `no-demangle` to false on default.



================
Comment at: llvm/test/tools/llvm-xray/X86/convert-with-debug-syms-no-demangle.txt:1
+; RUN: llvm-xray convert -m %S/Inputs/elf64-sample-o2.bin --symbolize --symbolize-no-demangle=true %S/Inputs/naive-log-simple.xray -f=yaml -o - 2>&1 | FileCheck %s
+
----------------
MaskRay wrote:
> This can be added to `X86/extract-instrmap-symbolize.ll` rather than add a new file.
> This can be added to `X86/extract-instrmap-symbolize.ll` rather than add a new file.

`llvm xray convert` and `llvm xray extract` are different subcommand, to avoid adding a new file, perhaps add this to `X86/convert-with-debug-syms.txt` ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108019/new/

https://reviews.llvm.org/D108019