[PATCH] D108092: [AsmPrinter] fix nullptr dereference for MBBs with hasAddressTaken property without BB

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 15 14:29:26 PDT 2021


dblaikie added a comment.

In D108092#2945743 <https://reviews.llvm.org/D108092#2945743>, @ivafanas wrote:

> In D108092#2945714 <https://reviews.llvm.org/D108092#2945714>, @dblaikie wrote:
>
>> Could you add a test case for this? Or is it not reachable with any existing/in-tree target?
>
> Yes, we have got a crash on custom out-of-tree target.
> I've reviewed in-tree targets where `setHasAddressTaken` is called and have not found MBB without BB.
>
> Summary message to this review http://reviews.llvm.org/D13774 gives me a bit of hope that fix will be accepted.

Fair enough - I'll leave this one to @rnk then


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108092/new/

https://reviews.llvm.org/D108092



More information about the llvm-commits mailing list