[PATCH] D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag

[Pirama Arumuga Nainar via Phabricator via llvm-commits]

pirama added a comment.

In D108006#2944140 <https://reviews.llvm.org/D108006#2944140>, @MaskRay wrote:

> Ideally test coverage improvement should be a separate patch.

Ack.

> I find a patch in https://android.googlesource.com/toolchain/llvm_android/+/refs/heads/master/patches/Revert-two-changes-that-break-Android-builds.v6.patch which may be related to the intention of this patch.
> Can you verify whether the proposed --no-search-static-libs-for-shlib-undefined can replace it?
> The patch touches `shouldDefineSym`, which means there is probably another missing test coverage: a symbol assignment which is referenced by a shared object and defined by an unextracted archive.

This goal of this patch is indeed to replace/remove the "Revert-two-changes" downstream patch.  I verified that [this patch + remove downstream patch] successfully builds the cuttlefish Android target.  I'll also build a few more targets to validate.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108006/new/

https://reviews.llvm.org/D108006