[PATCH] D108006: [lld][ELF] Add --no-search-static-libs-for-shlib-undefined flag
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Aug 13 11:19:17 PDT 2021
MaskRay added a comment.
Ideally test coverage improvement should be a separate patch.
I find a patch in https://android.googlesource.com/toolchain/llvm_android/+/refs/heads/master/patches/Revert-two-changes-that-break-Android-builds.v6.patch which may be related to the intention of this patch.
Can you verify whether the proposed --no-search-static-libs-for-shlib-undefined can replace it?
The patch touches `shouldDefineSym`, which means there is probably another missing test coverage: a symbol assignment which is referenced by a shared object and defined by an unextracted archive.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108006/new/
https://reviews.llvm.org/D108006
More information about the llvm-commits
mailing list