[PATCH] D107748: [MC][ELF] Mark Solaris objects as ELFOSABI_SOLARIS

[Rainer Orth via Phabricator via llvm-commits]

ro marked 3 inline comments as done.
ro added inline comments.


================
Comment at: llvm/test/MC/ELF/osabi-solaris.s:1
+# REQUIRES: x86-registered-target
+# RUN: llvm-mc -filetype=obj -triple amd64-solaris %s | llvm-readobj -hS - | FileCheck %s
----------------
MaskRay wrote:
> Drop. The whole directory requires x86.
Ah, I missed the `lit.local.cfg` file.


================
Comment at: llvm/test/MC/ELF/osabi-solaris.s:2
+# REQUIRES: x86-registered-target
+# RUN: llvm-mc -filetype=obj -triple amd64-solaris %s | llvm-readobj -hS - | FileCheck %s
+# CHECK: OS/ABI: Solaris
----------------
MaskRay wrote:
> -triple=amd64-solaris
> 
> Use `=` or ` ` consistently
I've gone for ' ', but the whole directory is a mess:

`-filetype`: 228 x '=',     4 x  ' '
`-triple`:        41 x '=', 223 x ' '


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107748/new/

https://reviews.llvm.org/D107748