[PATCH] D107748: [MC][ELF] Mark Solaris objects as ELFOSABI_SOLARIS

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/test/MC/ELF/osabi-solaris.s:1
+# REQUIRES: x86-registered-target
+# RUN: llvm-mc -filetype=obj -triple amd64-solaris %s | llvm-readobj -hS - | FileCheck %s
----------------
Drop. The whole directory requires x86.


================
Comment at: llvm/test/MC/ELF/osabi-solaris.s:2
+# REQUIRES: x86-registered-target
+# RUN: llvm-mc -filetype=obj -triple amd64-solaris %s | llvm-readobj -hS - | FileCheck %s
+# CHECK: OS/ABI: Solaris
----------------
-triple=amd64-solaris

Use `=` or ` ` consistently


================
Comment at: llvm/test/MC/ELF/osabi-solaris.s:5
+
+.text
----------------
unneeded


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107748/new/

https://reviews.llvm.org/D107748