[PATCH] D105854: [PowerPC] Inefficient register allocation of ACC registers results in many copies.
Qiu Chaofan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Aug 12 20:53:56 PDT 2021
qiucf added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/TargetRegisterInfo.h:876
+ /// local ranges when registers are added to the queue.
+ virtual bool addAllocPriorityToGlobalRanges() const { return false; }
+
----------------
arsenm wrote:
> Why is this a target option? Why not just always apply the target defined priority? It seems like a bug to me that this wasn't added before
I think it breaks lots of AMDGPU tests (30+) so it will go beyond this patch's scope. I'm not sure it's better or worse for AMDGPU, so I posted https://reviews.llvm.org/D108010.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105854/new/
https://reviews.llvm.org/D105854
More information about the llvm-commits
mailing list