[PATCH] D107953: [Flang] test_symbols.py module file fix

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 12 12:34:15 PDT 2021


awarzynski added a comment.

In D107953#2941417 <https://reviews.llvm.org/D107953#2941417>, @Meinersbur wrote:

> Is there a reason to use lit's suggestion for a temporary directory instead using `tempfile.TemporaryDirectory` or `tempfile.mkdtemp`?

I like this suggestion - with `tempfile.TemporaryDirectory` the tests wouldn't require the extra argument (`%t`). Is the temporary directory name guaranteed to be unique to every test? That wasn't 100% obvious to me from the docs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107953/new/

https://reviews.llvm.org/D107953



More information about the llvm-commits mailing list