[PATCH] D107953: [Flang] test_symbols.py module file fix

Ivan Zhechev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 12 07:50:03 PDT 2021


ijan1 added a comment.

In D107953#2941417 <https://reviews.llvm.org/D107953#2941417>, @Meinersbur wrote:

> Is there a reason to use lit's suggestion for a temporary directory instead using `tempfile.TemporaryDirectory` or `tempfile.mkdtemp`?

I decided to use what's already in the LIT and it also more accurately reflects the behaviour of the bash script. Besides that, I don't see a reason why I couldn't use the `tempfile` library.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107953/new/

https://reviews.llvm.org/D107953



More information about the llvm-commits mailing list