[PATCH] D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1116-1118
+  if (EnableFSDiscriminator)
+    addPass(createMIRAddFSDiscriminatorsPass(
+        sampleprof::FSDiscriminatorPass::Pass1));
----------------
wmi wrote:
> How about adding a comment that the pass is intentionally placed before regalloc, in case some other passes are inserted in between in the future. 
name `FSDiscriminatorPass::Pass1` as something like `FSDiscriminatorPass::RegAlloc` might help too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104579/new/

https://reviews.llvm.org/D104579