[PATCH] D104579: [SampleFDO] Add two passes of MIRAddFSDiscriminatorsPass

Wei Mi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 11 08:55:58 PDT 2021


wmi accepted this revision.
wmi added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1116-1118
+  if (EnableFSDiscriminator)
+    addPass(createMIRAddFSDiscriminatorsPass(
+        sampleprof::FSDiscriminatorPass::Pass1));
----------------
How about adding a comment that the pass is intentionally placed before regalloc, in case some other passes are inserted in between in the future. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104579/new/

https://reviews.llvm.org/D104579



More information about the llvm-commits mailing list